Skip to content

Feature: improve VideoCard Performance (+ remove GifVideo)

Cody Adam requested to merge feat/improved-video-card into main
  • Now if the video URL is a video.igem.org domain it will fetch the thumbnail and display it instead of loading the iframe
  • You can now add a customThumbnail as parameter (which make the GifVideo deprecated → I removed it)
  • The usage of VideoCard is unchanged

Note: One of the original idea was to replace the props to enforce to use video ID instead of embed URLs. The problem I run into is that :

  1. There are also URL that are not on the video.igem.org domain, so it will require maybe another prop field for this ? (but this is minor we can work around this)
  2. There are two types of video.igem.org links, videos (ex: https://video.igem.org/videos/embed/1cfcd8d9-9a4e-42ae-9451-21267b4860b4) or video-playlists (https://video.igem.org/video-playlists/embed/1cfcd8d9-9a4e-42ae-9451-21267b4860b4) and if we only ask for the ID on the props, we can't get the thumbnail because of the peertube api route for the thumb that are different.
Edited by Cody Adam

Merge request reports