Skip to content

remove VITE_IGEM_WEBSITE env var

Fabio Maschi requested to merge fix/remove-igem-website-env into main

Please read this:

  • env vars are used to change the value between local, dev and prod.
  • the prod value for VITE_IGEM_WEBSITE is https://igem.org
  • the local value of it is usually http://loalhost:3030
  • however, the dev value of it is always unknown, since it varies for every dev branch that we create

It's very, very unlikely that you need to setup VITE_IGEM_WEBSITE for something else than https://igem.org. If you do, treat as a debug line, where you hardcode the DEV url, and change it back to https://igem.org before merging.

Currently, the DEV value of VITE_IGEM_WEBSITE is https://review.igem.org/igem/feat-privacy-policy, which doesn't exist, so it creates the illusion that by using VITE_IGEM_WEBSITE the dev deployment will work. This also makes us creating the login endpoint as ${VITE_IGEM_WEBSITE}/login}, which won't work neither.

For login in dev, please check https://gitlab.igem.org/websites/igem/-/merge_requests/99

Edited by Fabio Maschi

Merge request reports

Loading